Search Linux Wireless

Re: [PATCH MOREWORK 18/19] iwl4965: Fix more memory leaks in __il4965_up()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 18, 2016 at 01:29:11PM +1100, Julian Calaby wrote:
> In some of the non-success return paths, the memory allocated by
> iwl4965_sta_alloc_lq() in iwl4965_alloc_bcast_station() is not freed.
> 
> In particular:
>  - if the card isn't ready after il4965_prepare_card_hw()
>  - if the card is hardware-rfkilled
> 
> In the hardware rfkilled path, the driver enables the rfkill
> interrupt. When the card is unrfkilled and this interrupt is raised
> we end up calling il4965_bg_restart() which calls __il4965_up() which
> calls iwl4965_alloc_bcast_station() again.
> 
> Suggested-by: Jia-Ju Bai <baijiaju1990@xxxxxxx>
> Signed-off-by: Julian Calaby <julian.calaby@xxxxxxxxx>
> 
> ---
> 
> This is only compile tested as I don't have compatible hardware. I also
> don't know the driver enough to know that this is truly correct - however
> it looks right and I stand by my analysis.
> 
> Could someone else please review this?

Looks ok.

Acked-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux