Search Linux Wireless

Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 19, 2016 at 09:21:52AM +0100, Vishal Thanki wrote:
> On Sat, Mar 19, 2016 at 9:06 AM, Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote:
> > On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote:
> >>
> >> @@ -1001,6 +1002,9 @@ struct rt2x00_dev {
> >>
> >>       /* Extra TX headroom required for alignment purposes. */
> >>       unsigned int extra_tx_headroom;
> >> +
> >> +     struct usb_anchor *anchor;
> >> +     void (*kill_anchored_urbs)(struct rt2x00_dev *);
> > ...
> >> @@ -1423,6 +1423,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
> >>       cancel_delayed_work_sync(&rt2x00dev->autowakeup_work);
> >>       cancel_work_sync(&rt2x00dev->sleep_work);
> >>       if (rt2x00_is_usb(rt2x00dev)) {
> >> +             rt2x00dev->kill_anchored_urbs(rt2x00dev);
> > ...
> >>
> >> +static void rt2x00usb_kill_anchored_usb(struct rt2x00_dev *rt2x00dev)
> >> +{
> >> +     usb_kill_anchored_urbs(rt2x00dev->anchor);
> >> +}
> > ...
> >> +     rt2x00dev->kill_anchored_urbs = rt2x00usb_kill_anchored_usb;
> >
> > Why do you complicate things, instead of call usb_kill_anchored_urbs()
> > directly?
> >
> 
> I tried to compile by disabling the CONFIG_USB from kernel, and was getting
> error for missing symbol usb_kill_anchored_urbs.

Ok, just around if(rt2x00_is_usb) section by #ifdef RT2X00_LIB_USB. Or
you can try to modify rt2x00_is_usb to always return false if RT2X00_LIB_USB
is not configured - perhaps that will also prevent compilation failure
without USB support.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux