On Mon, 2016-03-14 at 10:50 -0700, Greg Kroah-Hartman wrote:
[
> 4.4-stable review patch. If anyone has any objections, please let me know.
I don't have any objections, so I dropped Greg and stable from the
recipients.
[...]
> --- a/net/wireless/wext-core.c
> +++ b/net/wireless/wext-core.c
[...]
> static int __init wireless_nlevent_init(void)
> {
> - return register_pernet_subsys(&wext_pernet_ops);
> + int err = register_pernet_subsys(&wext_pernet_ops);
> +
> + if (err)
> + return err;
> +
> + return register_netdevice_notifier(&wext_netdev_notifier);
> }
[...]
In practice this is safe as register_netdevice_notifier() will only
return an error if your notifier does so, which it does not. But it
seem like a good idea to future-proof it by adding a check for failure
and calling unregister_pernet_subsys() in that case.
Ben.
l
--
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.Attachment:
signature.asc
Description: This is a digitally signed message part
