Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes: > Jes.Sorensen@xxxxxxxxxx writes: > >> From: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx> >> >> This implements the 8723bu specific power on sequence as it is >> different from that of the 8723au chips. >> >> Signed-off-by: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx> > > [...] > >> @@ -140,7 +144,10 @@ >> #define REG_MAC_PINMUX_CFG 0x0043 >> #define REG_GPIO_PIN_CTRL 0x0044 >> #define REG_GPIO_INTM 0x0048 >> +#define GPIO_INTM_EDGE_TRIG_IRQ BIT(9) >> + >> #define REG_LEDCFG0 0x004c >> +#define LEDCFG0_DPDT_SELECT BIT(23) >> #define REG_LEDCFG1 0x004d >> #define REG_LEDCFG2 0x004e >> #define LEDCFG2_DPDT_SELECT BIT(7) >> @@ -154,9 +161,13 @@ >> #define REG_GPIO_PIN_CTRL_2 0x0060 >> /* RTL8723 WIFI/BT/GPS Multi-Function GPIO Select. */ >> #define REG_GPIO_IO_SEL_2 0x0062 >> +#define GPIO_IO_SEL_2_GPIO09_INPUT BIT(1) >> +#define GPIO_IO_SEL_2_GPIO09_IRQ BIT(9) >> >> /* RTL8723B */ >> #define REG_PAD_CTRL1 0x0064 >> +#define PAD_CTRL1_SW_DPDT_SEL_DATA BIT(0) > > Why two spaces after define? I use two spaces for bit defines, so it refers to the register above. It's consistent throughout the code. Jes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html