On Fri, 2016-03-04 at 21:22 +0100, Bjørn Mork wrote:
> "Coelho, Luciano" <luciano.coelho@xxxxxxxxx> writes:
> > On Fri, 2016-03-04 at 19:53 +0100, Bjørn Mork wrote:
> >
> > > Still think it's unwise to leave ERR_PTR's around though.
> >
> > The main point is that we don't want to fail the entire driver
> > loading
> > if the thermal zone (or cooling device) registration fails. We
> > have a
> > fallback for that, which is what was used before this new
> > implementation (namely, the thermal throttling code in the driver).
>
> Sure. I just think it is cleaner to replace the ERR_PTR with NULL
> before returning. Minor nit of course. I wouldn't have bothered
> with
> it if I hadn't wrongly thought that it would crash,
Thanks a lot for reviewing!
--
Cheers,
Luca.��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
