Hi Kalle, On Fri, 2016-03-04 at 18:07 +0200, Kalle Valo wrote: > Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> writes: > > > From: Matti Gottlieb <matti.gottlieb@xxxxxxxxx> > > > > If the opmode is stopped and started again we did not free > > the paging buffers. Fix that. > > In addition when freeing the firmware's paging download > > buffer, set the pointer to NULL. > > > > Signed-off-by: Matti Gottlieb <matti.gottlieb@xxxxxxxxx> > > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> > > Nitpicking while writing the pull request for Dave: > > What does "opmode is stopped" mean? Important bug fixes should have a > clear bug description from user's point of view. Using driver internal > jargon is gibberish to most people. I agree that there could be a bit more high-level description here, but I also think it's good to keep a bit more details about what is happening internally, so that developers understand too. ;) Do you think it would be acceptable to keep the commit log most as it is, but start with something like "Some paging buffers were not freed when the driver is restarted."? I don't mean to change this commit itself, but just so that we know how to please you (and users) while still keeping the details as part of the commit logs... ;) > I investigated this myself and apparently "opmode" is stopped when the > module is unloaded or the PCI device is removed. So just say that in the > commit log and everyone understand much better. Our driver is divided roughly into two layers: the bus layer (called transport) and the protocol layer (called opmode). The name comes from the difference between the two opmodes that we currently have. One supports only a single operating channel (dvm) and the other supports multiple operating channels (mvm). Hope this clarifies a bit. :) -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
