On 3-3-2016 16:55, Johannes Berg wrote: > On Wed, 2016-03-02 at 20:37 +0100, Arend van Spriel wrote: >> Introducing a new feature that the driver can use to >> indicate the driver/firmware supports configuration of BSS >> selection criteria upon CONNECT command. This can be useful >> when multiple BSS-es are found belonging to the same ESS, >> ie. Infra-BSS with same SSID. The criteria can then be used to >> offload selection of a preferred BSS. >> > Applied, finally :) Yeah. I was afraid it would not make it in 4.6. > I moved the wiphy supported methods check into parse_bss_select() to > avoid the double error path in the caller, plus some editorial changes. Looking at it + /* user-space did not provide behaviour attribute */ + if (bss_select->behaviour == __NL80211_BSS_SELECT_ATTR_INVALID) + return -EINVAL; + + if (!(wiphy->bss_select_support & BIT(bss_select->behaviour))) + return -EINVAL; the first check is (and already was) redundant. Regards, Arend -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
