Hi Andreas,
On Thu, Feb 25, 2016 at 11:08 AM, Andreas Fenkart <afenkart@xxxxxxxxx> wrote:
> after factoring out mwifiex_cancel_pending_scan_cmd
> the function is noc called outside of cmdevt file
>
> Signed-off-by: Andreas Fenkart <afenkart@xxxxxxxxx>
> ---
> drivers/net/wireless/marvell/mwifiex/cmdevt.c | 6 +++++-
> drivers/net/wireless/marvell/mwifiex/main.h | 2 --
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> index 61426b3..4b0f44d 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> @@ -26,6 +26,10 @@
> #include "11n.h"
> #include "11ac.h"
>
> +static void
> +mwifiex_insert_cmd_to_free_q(struct mwifiex_adapter *adapter,
> + struct cmd_ctrl_node *cmd_node);
> +
Why not just move the function definition above where it's needed?
> /*
> * This function initializes a command node.
> *
> @@ -619,7 +623,7 @@ int mwifiex_send_cmd(struct mwifiex_private *priv, u16 cmd_no,
> * The function also calls the completion callback if required, before
> * cleaning the command node and re-inserting it into the free queue.
> */
> -void
> +static void
> mwifiex_insert_cmd_to_free_q(struct mwifiex_adapter *adapter,
> struct cmd_ctrl_node *cmd_node)
> {
> diff --git a/drivers/net/wireless/marvell/mwifiex/main.h b/drivers/net/wireless/marvell/mwifiex/main.h
> index f71f894..840e5d4 100644
> --- a/drivers/net/wireless/marvell/mwifiex/main.h
> +++ b/drivers/net/wireless/marvell/mwifiex/main.h
> @@ -1045,8 +1045,6 @@ void mwifiex_cancel_all_pending_cmd(struct mwifiex_adapter *adapter);
> void mwifiex_cancel_pending_ioctl(struct mwifiex_adapter *adapter);
> void mwifiex_cancel_pending_scan_cmd(struct mwifiex_adapter *adapter);
>
> -void mwifiex_insert_cmd_to_free_q(struct mwifiex_adapter *adapter,
> - struct cmd_ctrl_node *cmd_node);
> void mwifiex_recycle_cmd_node(struct mwifiex_adapter *adapter,
> struct cmd_ctrl_node *cmd_node);
>
> --
> 2.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
