Search Linux Wireless

RE: [PATCH V2 18/24] staging: wilc1000: linux_wlan.c: removes unnecessary log messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Julian,

Yes, ongoing remove this function.
I will be removing this function for next patch.
Thank you in your advice.

 Thanks, BR
 Leo

-----Original Message-----
From: Julian Calaby [mailto:julian.calaby@xxxxxxxxx] 
Sent: Friday, February 19, 2016 9:41 AM
To: Kim, Leo <Leo.Kim@xxxxxxxxx>
Cc: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>; devel@xxxxxxxxxxxxxxxxxxxx; linux-wireless <linux-wireless@xxxxxxxxxxxxxxx>; Cho, Tony <Tony.Cho@xxxxxxxxx>; Lee, Glen <Glen.Lee@xxxxxxxxx>; Shin, Austin <Austin.Shin@xxxxxxxxx>; Park, Chris <Chris.Park@xxxxxxxxx>; Abozaeid, Adham <Adham.Abozaeid@xxxxxxxxx>; Ferre, Nicolas <Nicolas.FERRE@xxxxxxxxx>
Subject: Re: [PATCH V2 18/24] staging: wilc1000: linux_wlan.c: removes unnecessary log messages

Hi Leo,

On Thu, Feb 18, 2016 at 10:30 PM, Leo Kim <leo.kim@xxxxxxxxx> wrote:
> From: Chris Park <chris.park@xxxxxxxxx>
>
> This patch removes unnecessary log messages.
>
> Signed-off-by: Chris Park <chris.park@xxxxxxxxx>
> Signed-off-by: Leo Kim <leo.kim@xxxxxxxxx>
> ---
>  drivers/staging/wilc1000/linux_wlan.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> index a731b46..660bf63 100644
> --- a/drivers/staging/wilc1000/linux_wlan.c
> +++ b/drivers/staging/wilc1000/linux_wlan.c
> @@ -226,7 +226,6 @@ static void deinit_irq(struct net_device *dev)
>
>  void wilc_dbg(u8 *buff)
>  {
> -       PRINT_D(INIT_DBG, "%d\n", *buff);
>  }

Are you sure this is right? If so, why not just remove this function entirely?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux