On 18 February 2016 at 13:34, Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote: > From: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx> > > On error we jumped to the label bcma_out and returned the error code but > we missed freeing dev. What if b43_one_core_attach fails? Won't we miss kfree then as well? Shouldn't you simply improve error path and maybe use an additional label? Also may we be missing a proper free in b43_bcma_remove as well? Your patch subject could also be a bit more descriptive (e.g. what memory leak exactly is it). -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
