Hi All,
On Tue, Feb 16, 2016 at 6:04 AM, Alan <gnomes@xxxxxxxxxxxxxxxxxxx> wrote:
> The buffer needs to be zero terminated in case the user data is not.
> Otherwise we run off the end of the buffer.
>
> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
This looks right to me.
Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx>
> ---
> drivers/net/wireless/ralink/rt2x00/rt2x00debug.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c b/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
> index 25ee3cb..72ae530 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
> @@ -478,7 +478,7 @@ static ssize_t rt2x00debug_write_##__name(struct file *file, \
> { \
> struct rt2x00debug_intf *intf = file->private_data; \
> const struct rt2x00debug *debug = intf->debug; \
> - char line[16]; \
> + char line[17]; \
> size_t size; \
> unsigned int index = intf->offset_##__name; \
> __type value; \
> @@ -494,7 +494,8 @@ static ssize_t rt2x00debug_write_##__name(struct file *file, \
> \
> if (copy_from_user(line, buf, length)) \
> return -EFAULT; \
> - \
> + line[16] = 0; \
> + \
> size = strlen(line); \
> value = simple_strtoul(line, NULL, 0); \
> \
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
