Search Linux Wireless

Re: [PATCH] codel: add forgotten inline to functions in header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



fixing linux-wireless address ...

On 02/11/2016 04:30 PM, Eric Dumazet wrote:
> On Thu, 2016-02-11 at 16:08 +0200, Emmanuel Grumbach wrote:
>> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
>> ---
>> -static bool codel_should_drop(const struct sk_buff *skb,
>> -			      struct Qdisc *sch,
>> -			      struct codel_vars *vars,
>> -			      struct codel_params *params,
>> -			      struct codel_stats *stats,
>> -			      codel_time_t now)
>> +static inline bool codel_should_drop(const struct sk_buff *skb,
>> +				     struct Qdisc *sch,
>> +				     struct codel_vars *vars,
>> +				     struct codel_params *params,
>> +				     struct codel_stats *stats,
>> +				     codel_time_t now)
>
> The lack of inline was done on purpose.
>
> This include file is kind of special, being included by codel and
> fq_codel.
>
> Hint : we do not want to force the compiler to inline
> codel_should_drop() (or any other function).
>
>
> See this file as if it was a .c really.
>
>

Yeah :) codel_should_drop seemed very long indeed... I wanted to use the
codel_get_time and associated utils (_before, _after) in iwlwifi.
They're better than jiffies... So maybe I can just copy that code to
iwlwifi.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux