Search Linux Wireless

Re: [PATCH 4/4] Staging: rtl8723au: core: rtw_ieee80211: Fixed a coding style Warning.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2016-02-01 at 18:21 +0530, Rakhi Sharma wrote:
> Fixed a braces style warning.
> Warning: braces {} are not necessary for single statement blocks.
[]
> diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
[]
> @@ -176,11 +176,9 @@ u8 *rtw_get_ie23a(u8 *pbuf, int index, int *len, int limit)
>  	int tmp, i;
>  	u8 *p;
>  
> -	if (limit < 1) {
> +	if (limit < 1)
>  
>  		return NULL;
> -	}
> -
>  	p = pbuf;
>  	i = 0;
>  	*len = 0;

This ends up as:

	if (limit < 1)

		return NULL;
	p = pbuf;

And isn't particularly more readable.
It would be better as:

	if (limit < 1)
		return NULL;

	p = pbuf;
etc...
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux