Search Linux Wireless

Re: [PATCH] ath5k: Fix loop variable initializations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Have you checked this one...

1838                         if (rs.rs_status & AR5K_RXERR_MIC) {
1839                                 rxs.flag |= RX_FLAG_MMIC_ERROR;
1840                                 goto accept;

are you sure that doesn't happen ?

Also why initialize rxs.flag here?
> rxs.flag = RX_FLAG_TSFT;

Why not doing a simple
rxs.flag = 0 ;
or a check of flags set by mac80211 at the start of the loop ?

This way we'll also have a clean rxs.flag when doing
rxs.flag |= RX_FLAG_MMIC_ERROR
and we won't clear RX_FLAG_MMIC_ERROR when doing
rxs.flag = RX_FLAG_TSFT;

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux