On 01/25/2016 10:35 PM, Michal Kazior wrote:
On 25 January 2016 at 18:59, Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:
On 01/21/2016 05:23 AM, Michal Kazior wrote:
The driver can access the queue simultanously
while mac80211 tears down the interface. Without
spinlock protection this could lead to corrupting
sk_buff_head and subsequently to an invalid
pointer dereference.
Hard to know for certain, but this *appears* to fix the unexpectedly large
amount of CE/AXI ath10k firmware crashes that we saw in the 4.2 kernel (4.0
previously
ran much better han 4.2 for us).
That's impossible.
Without wake_tx_queue() txqs aren't even allocated (sdata->vif.txq is NULL).
You are right. But while testing, one of my guys did find a way to reproduce the
crash very quickly in 4.2. Happens fastest when I use the HTT-MGT variant
of my firmware, but same firmware works good-ish in 4.0. Seems I have something
to bisect now if I can get a minimal patch to apply each time to enable my
htt-mgt firmware feature...
The latest test case is to just to change the channel of the AP while station
is connected. Station sends some null-funcs, firmware resets it's low-level
stuff a bunch because it doesn't get AKCs, then CE/AXI crashes. Could be
my firmware or kernel modifications of course, though similar crash scenarios have been seen forever
in all sorts of firmwares and kernels.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
