On Wed, 2016-01-13 at 11:04 +0200, Lior David wrote:
>
> + * @NL80211_ATTR_PBSS: flag attribute. If set it means operate
> + * in a PBSS. Specified in %NL80211_CMD_CONNECT to request
> + * connecting to a PCP, and in %NL80211_CMD_START_AP to start
> + * a PCP instead of AP. Relevant for DMG networks only.
I'm continually confused by this; is it possible for DMG devices to be
a "real" AP rather than a PCP?
> @@ -3461,6 +3462,8 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info)
> return PTR_ERR(params.acl);
> }
>
> + params.pbss = nla_get_flag(info->attrs[NL80211_ATTR_PBSS]);
> +
> wdev_lock(wdev);
> err = rdev_start_ap(rdev, dev, ¶ms);
> if (!err) {
This, and the corresponding code in nl80211_connect, really ought to
check that the device is a DMG device and able to do this.
Perhaps this even needs a capability check, or do we assume that all
devices/drivers will be able to do this (or should reject it?)
If you want to rely on drivers though you need to have (in this patch!)
a small change to the existing driver to reject the operations if
pbss==true since obviously it cannot be doing the right thing right now
without further changes. That reject would then of course be removed
again with the driver update.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
