On Thu, 2016-01-21 at 16:58 +0200, Kalle Valo wrote: > Hi, > > I have quite a lot of random cleanup patches from new developers waiting > in my queue: > > https://patchwork.kernel.org/project/linux-wireless/list/?state=10&delegate=25621&order=date > > (Not all of them are cleanup patches, there are also few patches > deferred due to other reasons, but you get the idea.) > > These cleanup patches usually take quite a lot of my time and I'm > starting to doubt the benefit, compared to the time needed to dig > through them and figuring out what to apply. And this is of course time > away from other patches, so it's slowing down "real" development. > > I really don't know what to do. Part of me is saying that I just should > drop them unless it's reviewed by a more experienced developer but on > the other hand this is a good way get new developers onboard. > > What others think? Are these kind of patches useful? Some yes, mostly not really. While whitespace style patches have some small value, very few of the new contributors that use tools like "scripts/checkpatch.pl -f" on various kernel files actually continue on to submit actual defect fixing or optimization or code clarity patches. Whitespace patches, where git diff -w does not show any difference and objdiff on the objects for a few randconfigs are identical, maybe could be sifted into a separate category from other patches. Maybe the kbuild test robot could help identify the whitespace style patches that can be easily applied. Maybe the kernel-janitors list should be used and also maybe some maintainers that want these style patches could opt-in to getting these applied after some milestone like an -rc1. Fengguang? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
