On Mon, Jan 11, 2016 at 09:42:54PM +0800, Jia-Ju Bai wrote: > If "txq->cmd = kzalloc(...)" in il_tx_queue_init fails, > "kfree(txq->cmd[i])" in il_tx_queue_free and il_cmd_queue_free > in iwl4965_hw_txq_ctx_free will causes a null pointer dereference, > because txq->cmd is NULL at that time. > > This patch fixes this problem by adding a if-check before kfree. > To avoid double free in il_tx_queue_free and il_cmd_queue_free > caused by the fixing, txq->meta and txq->cmd in error handling code > of il_tx_queue_init are assigned null values. > Otherwise, a double free will occur. > > This patch has been tested in real device, and it actually fixes the bug. > Thanks Stanislaw for his suggestion. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@xxxxxxx> Acked-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
