On 01/07/2016 11:15 PM, Kalle Valo wrote: > Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> writes: > >> My commit below introduced a mutex in the transport to >> prevent concurrent operations. To do so, it added a flag >> (is_down) to make sure the transport is in the right state. >> This uncoverred an bug that didn't cause any harm until >> now: iwldvm calls stop_device and then starts the firmware >> without calling start_hw in between. While this flow is >> fine from the device configuration point of view (register, >> etc...), it is now forbidden by the new is_down flag. >> This led to this error to appear: >> iwlwifi 0000:05:00.0: Can't start_fw since the HW hasn't been started >> and the suspend would fail. >> >> This fixes: >> https://bugzilla.kernel.org/show_bug.cgi?id=109591 >> >> CC: <stable@xxxxxxxxxxxxxxx> [4.3+] >> Reported-by: Bogdan Bogush <bogdan.s.bogush@xxxxxxxxx> >> Fixes=fa9f3281cbb1 ("iwlwifi: pcie: lock start_hw / start_fw / stop_device") > No need to change this anymore, but this should be: > > Fixes: fa9f3281cbb1 ("iwlwifi: pcie: lock start_hw / start_fw / stop_device") > Added to my "do_no_screw_up_before_upstreaming.sh" script. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
