On 6 January 2016 at 11:44, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Tue, 2016-01-05 at 11:35 +0100, Janusz Dziedzic wrote: >> In case driver already set info->flags (eg. >> IEEE80211_TX_CTL_NO_CCK_RATE >> in ath9k driver), before this patch we skip this requested flags. > > I don't see how we "skip" them? > >> + unsigned int flags = info->flags; >> >> if (ieee80211_tx_prepare(sdata, &tx, NULL, skb) == TX_DROP) >> return false; >> >> info->band = band; >> info->control.vif = vif; >> info->hw_queue = vif->hw_queue[skb_get_queue_mapping(skb)]; >> + info->flags |= flags; > > tx_prepare() doesn't [seem to] do anything to the flags but twiddle a > few, so ? > Yes, you right - this patch is not needed. Thanks. BR Janusz -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
