Hi Kalle, > From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] > Sent: Tuesday, January 05, 2016 3:41 PM > To: Amitkumar Karwar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Nishant Sarmukadam; Jeff > CF Chen > Subject: Re: [PATCH 1/3] mwifiex: fix misleading firmware download > messages > > Amitkumar Karwar <akarwar@xxxxxxxxxxx> writes: > > > From: chunfan chen <jeffc@xxxxxxxxxxx> > > > > mwifiex_check_fw_status() checks firmware status and also check if > > WLAN is the winner for firmware downloading. > > > > Once we detect that other interface is downloading the firmware, we > > call this routine again with max poll count to wait until firmware is > > ready. > > > > This patch splits the routine to avoid checking winner status multiple > > times and ensures that correct warning messages are displayed. > > > > Firmware status poll count is also increased to 150. > > The title is somewhat misleading, you are doing a lot more than just > fixing messages. Also please clarify the concept here, especially about > "winner", "loser" and the other interface. > Thanks for review. I will submit updated version with below changes. 1) Change title to "mwifiex: firmware download enhancements" 2) Modified description to explain "winner", "loser" and the other interface concepts. > > Signed-off-by: chunfan chen <jeffc@xxxxxxxxxxx> > > It's good practise to capitalise the name. > Ack. Regards, Amitkumar Karwar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
