Search Linux Wireless

Re: [PATCH 1/1] staging: Fix bitshifts by wrong offsets in wilc1000/host_interface.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 01, 2015 at 11:49:55PM -0300, Mario J. Rugiero wrote:
> struct set_multicast uses (implicitly) sizeof(bool) to determine how many bytes to copy in
> Handle_SetMulticastFilter. Since that is implementation defined, it triggered sparse to
> rightfully complain about shifting a bigger value than supported.
> Since it was used as if assuming it was 32 bits, I replaced the bool member by a u32.
> Also, time_out and buf_size members of ba_session_info are u16, but while copying their
> bytes into ptr in Handle_AddBASession shift 16 bits for the second byte instead of 8 bits.
> This patch fixes those two issues.
> 
> Signed-off-by: Mario J. Rugiero <mrugiero@xxxxxxxxx>
> ---
>  drivers/staging/wilc1000/host_interface.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

How did you test this is correct?

Doesn't apply to my tree :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux