> Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] wrote: > > David Lin <dlin@xxxxxxxxxxx> writes: > > > On November 26, 2015 5:40 PM, Johannes Berg wrote: > >> On Thu, 2015-11-26 at 08:27 +0000, David Lin wrote: > >> > >> > > > +#ifdef CONFIG_SUPPORT_MFG > >> > > > >> > > This Kconfig variable doesn't exist. > >> > > > >> > > >> > The compile variable is used privately by Marvell and our customers > >> > in production line. > >> > >> Yeah, still. Make it a proper Kconfig variable, defaulting to off and > >> hidden under something, or remove it. It's extremely misleading to > >> have something called CONFIG_* when it's not a Kconfig variable. > >> > > > > I will change this compile variable from "CONFIG_SUPPORT_MFG" to > > "SUPPORT_MFG". > > Then it's still dead code which won't ever get compiled in upstream. > Please follow what Johannes suggested. > The code will be removed. > -- > Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
