Hi Brian, On Mon, 14 Dec 2015 09:30:11 -0800 Brian Norris <computersforpeace@xxxxxxxxx> wrote: > On Mon, Dec 14, 2015 at 06:14:10PM +0100, Boris Brezillon wrote: > > bcm47xxnflash_remove() is supposed to unregister the NAND device previously > > registered in bcm47xxnflash_probe(), but the current implementation just > > test for the always NULL ->mtd platform data field (and does not call the > > right function to unregister it). > > > > Kill the useless ->mtd field in struct bcma_nflash, and release the real > > NAND device in bcm47xxnflash_remove(). > > > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> > > Fixes: a5401370c520 ("mtd: prepare place for BCMA NAND flash driver(s)") > > Cc: Rafał Miłecki <zajec5@xxxxxxxxx> > > --- > > drivers/mtd/nand/bcm47xxnflash/main.c | 7 ++++--- > > include/linux/bcma/bcma_driver_chipcommon.h | 4 ---- > > 2 files changed, 4 insertions(+), 7 deletions(-) > > Hmm, looks awfully similar... > > http://patchwork.ozlabs.org/patch/554164/ My bad, I completely overlooked it, even though I was in Cc of this patch. I acked it, could you apply it before my series so that I can can adjust the bcma patch? Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html