On 12/10/2015 11:24 AM, Arend van Spriel wrote:
On 09-12-15 14:06, Kalle Valo wrote:
Arend van Spriel <arend@xxxxxxxxxxxx> writes:
From: Hante Meuleman <meuleman@xxxxxxxxxxxx>
Please, no empty commit logs. For a patch like this it takes like 30
seconds to write a short log describing why and how you are simplifying
the code. Next year I'm thinking of start rejecting patches without a
commit log.
Time to consider new year resolutions, heh ;-) Anyway, it is noted and
will see if I can gatekeep this better.
This is a minor nitpick but it's not that common to the commit title
with a period.
Have to agree to the nitpicking part :-p Can keep it in mind though.
Reviewed-by: Arend Van Spriel <arend@xxxxxxxxxxxx>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@xxxxxxxxxxxx>
Signed-off-by: Hante Meuleman <meuleman@xxxxxxxxxxxx>
Change-Id: Ie179527eb29f2ed8b7869dac24591e2513775393
Reviewed-on: http://hnd-swgit.sj.broadcom.com:8080/5445
Reviewed-by: brcm80211 ci <brcm80211-ci@xxxxxxxxxxxx>
Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx>
Forgot to clean the tags? :)
*sigh* Obviously. Should not try to multitask when preparing patch series.
Do you want me to resend after cleaning it up?
Gr. AvS
Gr. AvS
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
