The function can return negative values, so its result should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx> --- drivers/nfc/fdp/fdp.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c index ccb07a1..440fac3 100644 --- a/drivers/nfc/fdp/fdp.c +++ b/drivers/nfc/fdp/fdp.c @@ -368,11 +368,10 @@ static int fdp_nci_patch_otp(struct nci_dev *ndev) goto out; /* Patch data connection creation */ - conn_id = fdp_nci_create_conn(ndev); - if (conn_id < 0) { - r = conn_id; + r = fdp_nci_create_conn(ndev); + if (r < 0) goto out; - } + conn_id = r; /* Send the patch over the data connection */ r = fdp_nci_send_patch(ndev, conn_id, NCI_PATCH_TYPE_OTP); @@ -439,11 +438,10 @@ static int fdp_nci_patch_ram(struct nci_dev *ndev) goto out; /* Patch data connection creation */ - conn_id = fdp_nci_create_conn(ndev); - if (conn_id < 0) { - r = conn_id; - goto out; - } + r = fdp_nci_create_conn(ndev); + if (r < 0) + got out; + conn_id = r; /* Send the patch over the data connection */ r = fdp_nci_send_patch(ndev, conn_id, NCI_PATCH_TYPE_RAM); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
