On 04/12/2015, Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote: > On 12/03/2015 12:21 PM, Johannes Berg wrote: >> On Thu, 2015-12-03 at 12:16 -0800, Ben Greear wrote: >>> ath10k wants to use vdev-id as a queue-id, and I want to support up >>> to >>> 64 vdevs. In the 4.2 kernel, this is causing splats when using lots >>> of >>> vdevs because then queue is out of range. >>> >>> Can we just increase IEEE80211_MAX_QUEUES to 64? >>> >> >> I think not, that would likely cause a lot of data structures to grow >> too much. We'd have to do more dynamic things in that case, I suppose. >> >> Does the original premise even make sense though? A single queue for >> each vdev seems a bit strange. > > Comments in ath10k claim that the approach makes per-vif tx locking > much easier and that is why that code was added.... This was introduced for qca6174 firmware which can do multi-channel and can hint host driver to stop/wake tx queues associated per vdev. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
