Search Linux Wireless

Re: [PATCH] mac80211_hwsim: stop using pointers as cookies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2015-11-08 at 18:49 -0500, Bob Copeland wrote:
> On Fri, Nov 06, 2015 at 11:57:23AM +0100, Johannes Berg wrote:
> > Instead of using pointers, use sequentially assigned cookies.
> > This is easier to understand while debugging and also avoids
> > problems when the pointer is reused for the next allocation.
> 
> I tested this out in wmediumd and it didn't go so well...
> 
> > +	info->rate_driver_data[0] = (void *)cookie;
> 
> [...]
> 
> > +		skb_cookie = (u64)(uintptr_t)txi->driver_data[0];
> 
> rate_driver_data vs driver_data?

Yep, that fixes it. I've applied the patch with that fix.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux