Search Linux Wireless

Re: [PATCH] mac80211: Add RTNL version of ieee80211_iterate_active_interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	 * requested configurations, make sure to use
> +	 * the _rtnl version since the regular version
> +	 * requires atomic context.

That's a bit misleading, the regular version requires that the callback
is atomic :)

> +	 */
> +	rtnl_lock();
> +	ieee80211_iterate_active_interfaces_rtnl(rt2x00dev->hw,
> +						 rt2x00lib_intf_scheduled_iter,
> +						 rt2x00dev);
> +	rtnl_unlock();

>  /**
> + * ieee80211_iterate_active_interfaces_rtnl - iterate active interfaces
> + *
> + * This function iterates over the interfaces associated with a given
> + * hardware that are currently active and calls the callback for them.
> + * This function allows the iterator function to sleep, the caller is
> + * responsible for proper locking mechanisms to prevent concurrency.

That description seems misleading. Also, since the mac80211 internal
list management could possibly change (I don't see it changing but who
knows), I think I'd prefer if this function acquired the rtnl itself
didn't have rtnl in the name. Can't think of a good name right now,
maybe rename the other one to _atomic?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux