On Thu, 2015-11-26 at 15:03 +0300, Dan Carpenter wrote: > > 2793 if (lq_sta && !lq_sta->pers.drv) { > ^^^^^^ > Check. > > 2794 IWL_DEBUG_RATE(mvm, "Rate scaling not > initialized yet.\n"); > 2795 mvm_sta = NULL; > 2796 } > 2797 > 2798 /* Send management frames and NO_ACK data using > lowest rate. */ > 2799 if (rate_control_send_low(sta, mvm_sta, txrc)) > 2800 return; > 2801 > 2802 iwl_mvm_hwrate_to_tx_rate(lq_sta->last_rate_n_flags, > ^^^^^^^^^^^^^^^^^^^^^^^^^ > Uchecked dereference. > Yeah, this is a bit tricky. If you look into rate_control_send_low(), I'm sure it'll return true when mvm_sta argument is NULL. Not sure how, if at all, we could make that more explicit here. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html