Search Linux Wireless

Re: w35und: fixed nasty stack overflow, I can actually ssh over this

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Pavel Machek <pavel@xxxxxxx> wrote:

> Removed nasty stack overflow, and got transmit of big packets to work. 
> I can now actually do ssh over softmac-based driver.
> 
> Unindent code to make it more readable.

> --- a/arch/x86/kernel/traps_32.c
> +++ b/arch/x86/kernel/traps_32.c
> @@ -146,11 +146,16 @@ static inline unsigned long print_contex
>  				unsigned long *stack, unsigned long bp,
>  				const struct stacktrace_ops *ops, void *data)
>  {
> +	int max = 5;
>  	struct stack_frame *frame = (struct stack_frame *)bp;
>  
>  	while (valid_stack_ptr(tinfo, stack, sizeof(*stack))) {
>  		unsigned long addr;
>  
> +		if (!max)
> +			return;
> +		max--;
> +

hm, you got into an infinite loop here, right? Could you please send 
this bit as a separate patch - and i guess it should use 
kstack_depth_to_print instead of '5'?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux