Hi Kalle\Yanbo, On Mon, Nov 16, 2015 at 10:57:44PM +0200, Kalle Valo wrote: > "Li, Yanbo" <yanbol@xxxxxxxxxxxxxxxx> writes: > > >> > + /* The padding bytes's location is different on various chips */ > >> > + enum ath10k_loc_4addr_pad loc_4addr_pad; > >> > >> I think that loc prefix is a bit misleading, it reminds me of > >> locationing/positioning etc. What about ath10k_hw_4addr_pad? > >> > > > > > > There is already a FW feature defined as > > "ATH10K_FW_FEATURE_NO_NWIFI_DECAP_4ADDR_PADDIND" and the relative > > string is "no-4addr-pad", if we just remove the "loc" prefix, it may > > be confuse with this FW feature. > > > > How about we change the loc to offset in this case or any better suggestion? > > I did some naming changes in the pending branch: > > https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=42cd3832cd7c78bfeabb639a4086c7838fda5b57 > > Please review and let me know what you think. Please merge this change, as this is a critical fix (I hope Yanbo is fine with the change in naming convention). I went through the change, it looks good to me and I had tested the earlier version and it fixed a Repeater mode bug. regards, shafi > > -- > Kalle Valo > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
