Search Linux Wireless

Re: [RFC v4 8/8] mac80211: use Kconfig counters to determine feature optimisation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2015-11-13 at 11:29 -0500, Steven Rostedt wrote:

> > -	select MAC80211_HW_HAS_RATE_CONTROL_OFF
> > -	select MAC80211_HW_RX_INCLUDES_FCS_OFF
> 
> What happened to these two?

I removed the _OFF ones entirely, and instead with this patch am now
relying on modified logic:

 _on  = flags_counter > 0
 _off = flags_counter < driver_counter

So the ones that are requested _OFF no longer need to be listed in
Kconfig - that was the entire point of doing the count (increment)
thing since we can then add new flags without touching all the drivers
to select them to _OFF.

> > +config MAC80211_NUM_DRIVERS
> > +	int
> > +	depends on MAC80211
> 
> Why the depends? Does it make it 1 to start with?
> 

No, it just removes it from the Kconfig entirely when you don't even
have MAC80211 instead of leaving it set there to 0. Probably not really
necessary, or could be better to put them all inside an "if mac80211"
block.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux