Search Linux Wireless

Re: [RFC] mac80211: Don't encrypt beacons

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 05 May 2008, Johannes Berg wrote:
> Hi,
> 
> > This patch is intended to for your experimental patch:
> > 	019-mac80211-tx-info-skb-cb.patch
> > 
> > Beacons shouldn't be encryped, so mac80211 should set
> > the IEEE80211_TX_CTL_DO_NOT_ENCRYPT flag in tx info flags.
> > Otherwise the driver will cause a NULL pointer dereference
> > when it tries to access the info->control.hw_key which isn't
> > configured.
> 
> Shouldn't this apply before that change as well? I'll happily roll it
> into the skb->cb/txinfo patch, but it seems it should be there w/o that
> too.

Hmm, your absolutely right, I hadn't checked the wireless-testing code yet. :)
I only noticed this bug since a user had hostapd running on rt2x00.git with
rt61pci HW crypto enabled.
I'll respin the patch to apply for wireless-testing ;)

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux