Jes Sorensen <Jes.Sorensen@xxxxxxxxxx> writes: > Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes: >> Jes Sorensen <Jes.Sorensen@xxxxxxxxxx> writes: >> >>> Xose Vazquez Perez <xose.vazquez@xxxxxxxxx> writes: >>>> >>>> There is overlap of devices between rtl8xxxu and rtl8192cu: >>>> USB_VENDER_ID_REALTEK, 0x8176 >>>> USB_VENDER_ID_REALTEK, 0x8178 >>>> USB_VENDER_ID_REALTEK, 0x817f >>>> 0x7392, 0x7811 >>> >>> Yes >> >> What, are you saying that you didn't fix that? I did say in the last >> review round that we should not have duplicated device entries within >> drivers/net/wireless and I assumed you took care of that. >> >>> and there is also a clash with USB IDs between >>> drivers/staging/rtl8192u and drivers/net/wireless/realtek/rtlwifi - >>> this is nothing new. >> >> We should do things properly in under drivers/, I don't care what >> happens in staging and that's no excuse to do things badly. > > As I explained earlier, there is no way I can do that unless we remove > rtlwifi's rtl8192cu driver and that cannot happen due to the feature > differences. There are plenty of other conflicts and this is not a bug. Like I said earlier in rtl8xxxu review, I don't want to have two drivers supporting the same device. So either rtl8xxxu or rtlwifi supports the devices above, not both. And to my knowledge rtl8xxxu is still lacking in features, and it's a new driver, so it's best that rtlwifi continues to support these for the time being. Once rtl8xxxu catches up and we have a clear consensus we can make the switch. I'll send a patch in a jiffy, merge window is getting closer so we don't have any extra time. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
