On Sun, 2015-10-18 at 19:23 +0100, Ben Hutchings wrote:
> On Thu, 2015-10-15 at 13:40 +0300, Kalle Valo wrote:
> > In commit 40d14143b787 ("ath10k: add firmware 10.2.4.45 as firmware-4.bin") I
> > forgot to commit board.bin file and that's why it was not included in the
> > commit even I had added an entry to WHENCE. Add that now.
> >
> > At the same time also add Version field for firmware-4.bin.
> >
> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx>
> [...]
>
> I've applied this and the following 4 patches. However, I'm not
> entirely happy with copyright acknowledgements going into the
> notice_ath10k*.txt files which aren't referenced anywhere. It would be
> easy for downstream distributors to miss that they should be packaged
> along with the firmware blobs they relate to. Please can you combine
> these with the QCA licence file or add references to these files from
> WHENCE?
>
Also please make sure that all text files are encoded as UTF-8 (or
ASCII). A couple of the notices had quote characters which I
eventually worked out to be GB2312-encoded.
Ben.
--
Ben Hutchings
A free society is one where it is safe to be unpopular. - Adlai StevensonAttachment:
signature.asc
Description: This is a digitally signed message part
