Search Linux Wireless

Re: [PATCH 01/11] brcmfmac: expose device memory to devcoredump subsystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/14/2015 01:01 PM, Kalle Valo wrote:
Arend van Spriel <arend@xxxxxxxxxxxx> writes:

On 10/12/2015 10:59 AM, Kalle Valo wrote:
kbuild test robot <lkp@xxxxxxxxx> writes:

Hi Arend,

[auto build test ERROR on next-20151008 -- if it's inappropriate base, please ignore]

config: x86_64-randconfig-x011-201540 (attached as .config)
reproduce:
          # save the attached .config to linux build tree
          make ARCH=x86_64

All errors (new ones prefixed by >>):

     drivers/net/wireless/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init'
      void brcmf_debugfs_init(void)
           ^
     In file included from drivers/net/wireless/brcm80211/brcmfmac/bus.h:20:0,
                      from drivers/net/wireless/brcm80211/brcmfmac/debug.c:24:
     drivers/net/wireless/brcm80211/brcmfmac/debug.h:118:20: note: previous definition of 'brcmf_debugfs_init' was here
      static inline void brcmf_debugfs_init(void)
                         ^

Arend, are the kbuild errors valid? I would guess they are as
wireless-drivers-next should be in linux-next.

Actually they are not. I am not sure about the build infrastructure,
but the errors above can only occur when CONFIG_BRCMDBG is set, but
DEBUG is not. However, that can not happen as we have following line
in drivers/net/wireless/brcm80211/Makefile:

subdir-ccflags-$(CONFIG_BRCMDBG)	+= -DDEBUG

I didn't check the details but I'm still not convinced :) In my opinion
the code should always compile, with and without -DDEBUG. Anyways, I
pushed this script to the pending branch to get kbuild test this patch
once again.

Ok, Kalle

Let me try to be a bit more convincing ;-)

I checked out linux-next/master, taken the provided .config and ran:

$ make prepare
$ make M=scripts
$ make M=drivers/net/wireless/brcm80211

  WARNING: Symbol version dump ./Module.symvers
           is missing; modules will have no dependencies and modversions.

  CC      drivers/net/wireless/brcm80211/brcmfmac/cfg80211.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/chip.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/fwil.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/fweh.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/fwsignal.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/p2p.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/proto.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/common.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/core.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/firmware.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/feature.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/btcoex.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/vendor.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/bcdc.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/sdio.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/debug.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/tracepoint.o
  CC      drivers/net/wireless/brcm80211/brcmfmac/of.o
  LD      drivers/net/wireless/brcm80211/brcmfmac/brcmfmac.o
  LD      drivers/net/wireless/brcm80211/brcmfmac/built-in.o
  CC      drivers/net/wireless/brcm80211/brcmutil/utils.o
  CC      drivers/net/wireless/brcm80211/brcmutil/d11.o
  LD      drivers/net/wireless/brcm80211/brcmutil/brcmutil.o
  LD      drivers/net/wireless/brcm80211/brcmutil/built-in.o
  LD      drivers/net/wireless/brcm80211/built-in.o
  Building modules, stage 2.
  MODPOST 0 modules

No compile issues.

Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux