On Tuesday 13 October 2015 16:36:30 Sven Eckelmann wrote: > Drivers/devices without their own rate control algorithm can get the > information what rates they should use from either the radiotap header of > injected frames or from the rate control algorithm. But the parsing of the > legacy rate information from the radiotap header was removed in commit > e6a9854b05c1 ("mac80211/drivers: rewrite the rate control API"). > > The removal of this feature heavily reduced the usefulness of frame > injection when wanting to simulate specific transmission behavior. Having > rate parsing together with MCS rates and retry support allows a fine > grained selection of the tx behavior of injected frames for these kind of > tests. > > Signed-off-by: Sven Eckelmann <sven@xxxxxxxxxxxxx> > Cc: Simon Wunderlich <sw@xxxxxxxxxxxxxxxxxx> > Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > --- > > We have required the support for rate parsing (legacy + HT) for some tests. > It is already known that this may not be the best place to set this flag > (IEEE80211_TX_CTRL_RATE_INJECT) but the main flags field is already full. > There is also the problem that powersave could overwrite the rate control > fields - so either we disable powersave queueing or find a different > solution. > > But maybe this feature is also not wanted anymore in the mac80211 driver. > > Thanks, > Sven Sorry, this was meant as RFC but accidentally dropped the [RFC] when I regenerated the patch after fixing a part of the message. Kind regards, Sven
Attachment:
signature.asc
Description: This is a digitally signed message part.