> I think I've seen it take a few of the 5-second timeouts.
Do you you know for which commands this has been?
> I wouldn't like to decrease the maximum so drastically.
How far would you go?
Or: maybe there is another way to make "pccardctl eject"
work reasonably fast in the case of a retrying command. Any
idea?
BTW, it's easy to force this kind of error, in cmdresp.c:
if (resp->seqnum==5) {
lbs_deb_cmd("forced FAIL\n");
spin_unlock_irqrestore(&priv->driver_lock, flags);
ret = -1;
goto out;
}
> Also, that del_timer_sync() happens in the module unload path, doesn't
> it? I'd want to see why you think it isn't needed.
I thought that del_timer_sync() waits until the timer has been executed? If yes, then that's the wrong thing here, I want to unload quickly. Makes no sense to wait till the command_timer finally fires and re-sends the failed command.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
