> Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] writes: > > David Lin <dlin@xxxxxxxxxxx> writes: > > > The Linux driver for WRT1900AC. The work was initially developed as > > part of openwrt effort and maintained on https://github.com/kaloz/mwlwifi. > > > > This is still work in progress, with 8864 chipset more mature and > > tested, while 8897 for the similar use case is added recently. > > > > Signed-off-by: David Lin <dlin@xxxxxxxxxxx> > > [...] > > > +static void mwl_reg_notifier(struct wiphy *wiphy, > > + struct regulatory_request *request) { #ifdef CONFIG_OF > > + struct ieee80211_hw *hw; > > + struct mwl_priv *priv; > > + struct property *prop; > > + struct property *fcc_prop = NULL; > > + struct property *etsi_prop = NULL; > > + struct property *specific_prop = NULL; > > + u32 prop_value; > > + int i, j, k; > > + > > + hw = (struct ieee80211_hw *)wiphy_priv(wiphy); > > + priv = hw->priv; > > + > > + if (priv->pwr_node) { > > + for_each_property_of_node(priv->pwr_node, prop) { > > + if (strcmp(prop->name, "FCC") == 0) > > + fcc_prop = prop; > > + if (strcmp(prop->name, "ETSI") == 0) > > + etsi_prop = prop; > > + if ((prop->name[0] == request->alpha2[0]) && > > + (prop->name[1] == request->alpha2[1])) > > + specific_prop = prop; > > + } > > + > > + prop = NULL; > > + > > + if (specific_prop) { > > + prop = specific_prop; > > + } else { > > + if (request->dfs_region == NL80211_DFS_ETSI) > > + prop = etsi_prop; > > + else > > + prop = fcc_prop; > > + } > > + > > + if (prop) { > > + /* Reset the whole table */ > > + for (i = 0; i < SYSADPT_MAX_NUM_CHANNELS; i++) > > + memset(&priv->tx_pwr_tbl[i], 0, > > + sizeof(struct mwl_tx_pwr_tbl)); > > + > > + /* Load related power table */ > > + i = 0; > > + j = 0; > > + while (i < prop->length) { > > + prop_value = > > + be32_to_cpu(*(__be32 *) > > + (prop->value + i)); > > + priv->tx_pwr_tbl[j].channel = prop_value; > > + i += 4; > > + prop_value = > > + be32_to_cpu(*(__be32 *) > > + (prop->value + i)); > > + priv->tx_pwr_tbl[j].setcap = prop_value; > > + i += 4; > > + for (k = 0; k < SYSADPT_TX_POWER_LEVEL_TOTAL; > > + k++) { > > + prop_value = > > + be32_to_cpu(*(__be32 *) > > + (prop->value + i)); > > + priv->tx_pwr_tbl[j].tx_power[k] = > > + prop_value; > > + i += 4; > > + } > > + prop_value = > > + be32_to_cpu(*(__be32 *) > > + (prop->value + i)); > > + priv->tx_pwr_tbl[j].cdd = > > + (prop_value == 0) ? false : true; > > + i += 4; > > + prop_value = > > + be32_to_cpu(*(__be32 *) > > + (prop->value + i)); > > + priv->tx_pwr_tbl[j].txantenna2 = prop_value; > > + i += 4; > > + j++; > > + } > > + > > + /* Dump loaded power tabel */ > > + wiphy_info(hw->wiphy, "%s: %s\n", dev_name(&wiphy->dev), > > + prop->name); > > + for (i = 0; i < SYSADPT_MAX_NUM_CHANNELS; i++) { > > + struct mwl_tx_pwr_tbl *pwr_tbl; > > + char disp_buf[64]; > > + char *disp_ptr; > > + > > + pwr_tbl = &priv->tx_pwr_tbl[i]; > > + if (pwr_tbl->channel == 0) > > + break; > > + wiphy_info(hw->wiphy, > > + "Channel: %d: 0x%x 0x%x 0x%x\n", > > + pwr_tbl->channel, > > + pwr_tbl->setcap, > > + pwr_tbl->cdd, > > + pwr_tbl->txantenna2); > > + disp_ptr = disp_buf; > > + for (j = 0; j < SYSADPT_TX_POWER_LEVEL_TOTAL; > > + j++) { > > + disp_ptr += > > + sprintf(disp_ptr, "%x ", > > + pwr_tbl->tx_power[j]); > > + } > > + wiphy_info(hw->wiphy, "%s\n", disp_buf); > > + } > > + } > > + } > > +#endif > > +} > > + > > +static void mwl_process_of_dts(struct mwl_priv *priv) { #ifdef > > +CONFIG_OF > > + struct property *prop; > > + u32 prop_value; > > + > > + priv->dt_node = > > + of_find_node_by_name(pci_bus_to_OF_node(priv->pdev->bus), > > + "mwlwifi"); > > + if (!priv->dt_node) > > + return; > > + > > + /* look for all matching property names */ > > + for_each_property_of_node(priv->dt_node, prop) { > > + if (strcmp(prop->name, "marvell,2ghz") == 0) > > + priv->disable_2g = true; > > + if (strcmp(prop->name, "marvell,5ghz") == 0) > > + priv->disable_5g = true; > > + if (strcmp(prop->name, "marvell,chainmask") == 0) { > > + prop_value = be32_to_cpu(*((__be32 *)prop->value)); > > + if (prop_value == 2) > > + priv->antenna_tx = ANTENNA_TX_2; > > + > > + prop_value = be32_to_cpu(*((__be32 *) > > + (prop->value + 4))); > > + if (prop_value == 2) > > + priv->antenna_rx = ANTENNA_RX_2; > > + } > > + } > > + > > + priv->pwr_node = of_find_node_by_name(priv->dt_node, > > + "marvell,powertable"); > > +#endif > > +} > > The device tree bindings need a proper document in > Documentation/devicetree/bindings and reviewed by the device tree folks. > That might take some time as I suspect having something like regdomain in DT > will be problematic, so I recommend to take this out from initial submission > and resend later once properly acked by the device tree maintainers. > The code is used to handle mwlwifi proprietary parameters in DTS file. Basically it won't be conflicted with any existing bindings. Should I still take them out from initial submission? pcie-controller { pcie@1,0 { mwlwifi { marvell,2ghz = <0>; marvell,chainmask = <2 2>; marvell,powertable { * * * }; }; }; }; > -- > Kalle Valo Thanks, David -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
