Search Linux Wireless

Re: [PATCH] mac80211: incorrect shift direction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2008-04-27 at 18:00 +0300, Tomas Winkler wrote:
> On Sun, Apr 27, 2008 at 2:24 PM, Johannes Berg
> <johannes@xxxxxxxxxxxxxxxx> wrote:
> > On Sun, 2008-04-27 at 03:48 -0700, Harvey Harrison wrote:
> >  > Looks like  5d2cdcd4e85c5187db30a6b29f79fbbe59f39f78 got the
> >  > shifts wrong.
> >
> >  Aha! Thanks for tracking this down. We had a patch to fix this but were
> >  confused why the bug hadn't been noticed before. So it looks like it
> >  wasn't *present* before :)
> >
> What to say.... Shame on me.
> Tomas

This is precisely why I wrote the new unaligned access helpers going in
soon, I'll have this converted at that time.

This line will become:
iv32 = get_unaligned_le32(data + 4);

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux