Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Wed, 2015-09-02 at 22:39 -0400, Jes Sorensen wrote: >> >> I went back and looked at this, and now I remember why I wrote the code >> the way I did. The Realtek firmware handles rate control, so once I set >> IEEE80211_HW_HAS_RATE_CONTROL, I never see >> rate_flags & IEEE80211_TX_RC_USE_SHORT_PREAMBLE nor >> tx_info->control_short_preamble. In order to know whether to tell the >> firmware to request short preamble or not, I needed to track whether the >> sta supports it. >> >> Do you have a suggestion for how to handle this in a better way? >> > > Ah, this makes sense. There's an rc_update call or something like that, > that might have the requisite information. Not really sure off the top > of my head. I'll add a comment to the code explaining why it is done this way. I had a peak at the rate_control code earlier, but it wasn't obvious to me whether I should be using that API at all. Is there an explanation of the API and it's usage somewhere? Cheers, Jes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
