Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
> There were several bugs here.
>
> 1) The done label was in the wrong place so we didn't copy any
> information out when there was no command given.
>
> 2) We were using PAGE_SIZE as the size of the buffer instead of
> "PAGE_SIZE - pos".
>
> 3) snprintf() returns the number of characters that would have been
> printed if there were enough space. If there was not enough space
> (and we had fixed the memory corruption bug #2) then it would result
> in an information leak when we do simple_read_from_buffer(). I've
> changed it to use scnprintf() instead.
>
> I also removed the initialization at the start of the function, because
> I thought it made the code a little more clear.
>
> Fixes: 5e6e3a92b9a4 ('wireless: mwifiex: initial commit for Marvell mwifiex driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
I see a new warning:
drivers/net/wireless/mwifiex/debugfs.c:760:31: warning: pos may be used uninitialized in this function [-Wuninitialized]
Is it a valid warning or should I apply the patch anyway?
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
