On Tue, Aug 18, 2015 at 08:01:00PM -0700, Greg KH wrote: > On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote: > > This patch allows setting all options in the module's debug region > > options file 'wilc_debug_region'. This functionality allows the user > > to enable logging from all regions (initialization, locks, firmware > > etc.) of the driver. Logging from the following regions is enabled > > during the driver initialization: > > > > INIT_DBG, GENERIC_DBG, CFG80211_DBG, FIRM_DBG and HOSTAPD_DBG > > > > Before this change, the numerical value set is equal first byte of > > input minus 0x30 (ASCII value of '0'). Because of this, after a write > > to this debugfs file, it is difficult to predict the regions on which > > logging is enabled. > > > > The DBG_REGION_ALL now includes 3 additional regions TCP_ENH, SPIN_DEBUG > > and FIRM_DBG. > > Why did you add these extra ones? I added them because there is code support them and to avoid a holes in the range of the options. > > All of this should eventually just be deleted, as network drivers need > to use the networking driver debug interfaces, not their own crazy ones. In that case, can I assume that we are not going forward with this change? > > thanks, > > greg k-h Thank you, chandra -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
