> Commit e996db69833a (rtlwifi: rtl8192c: Add init codes for "fw_version"
> and "fw_subversion") added initialization for fw_version, but failed to
> note that the variable in the firmware header is little-endian. The
> following Sparse warning results:
>
> CHECK drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c
> drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c:242:36: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c:242:36: expected unsigned short [unsigned] [usertype] fw_version
> drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c:242:36: got restricted __le16 [usertype] version
>
> When fixing this problem, I noticed that several of the drivers contain
> nearly identical copies of the firmware header struct, and that only the one
> used in rtl8192c{e,u} had correct endian notation. The struct has been
> moved into a common header, and the other drivers will be fixed in
> subsequant patches.
>
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
Thanks, 6 patches applied to wireless-drivers-next.git:
e41c51359918 rtlwifi: rtl8192ce: rtl8192cu: Fix endian issue
7c24d086ef9c rtlwifi: rtl8723ae: rtl8723be: rtl8723com: Fix firmware header endian issues
253f10abb7c2 rtlwifi: rtl8821ae: Fix firmware endian issues
b290b57d18aa rtlwifi: rtl8192de: Fix firmware header endian issues
201b63c7c907 rtlwifi: rtl888ee: Fix firmware header endian issues
8d882bcf8274 rtlwifi: rtl8192ee: Fix firmware header endian issues
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
