Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> writes: > Raja Mani <rmani@xxxxxxxxxxxxxxxx> writes: > >> Existing phyerr event handlers directly uses phyerr header format >> (ie, struct wmi_phyerr and struct wmi_phyerr_event) in the code >> exactly on how firmware packs it. This is the problem in 10.4 fw >> specific phyerr event handling where it uses different phyerror >> header format. Before adding 10.4 specific handler, little bit of >> refactor is done in existing phyerr handlers. >> >> Two new abstracted structures (struct wmi_phyerr_ev_hdr_arg and >> struct wmi_phyerr_ev_arg) are introduced to remove dependency of using >> firmware specific header format in the code. So that firmware specific >> phyerror handlers can populate values to abstracted structures and >> the following code can use abstracted struct for further operation. >> >> .pull_phyerr_hdr is added newly to pull common phyerr header info >> like tsf, buf_len, number of phyerr packed. Existing .pull_phyerr >> handler is changed and called to parse every sub phyerrs in the event. >> >> Validated these refactoring on qca988x hw2.0 using fw 10.2.4 version. >> >> Signed-off-by: Raja Mani <rmani@xxxxxxxxxxxxxxxx> > > Thanks, applied. Actually I'll take it back, I dropped these as I see new warnings: drivers/net/wireless/ath/ath10k/wmi.c:3625:33: warning: restricted __le32 degrades to integer drivers/net/wireless/ath/ath10k/wmi.c:3627:38: warning: restricted __le32 degrades to integer drivers/net/wireless/ath/ath10k/wmi.c:3599:5: warning: symbol 'ath10k_wmi_10_4_op_pull_phyerr_ev' was not declared. Should it be static? -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
