Search Linux Wireless

RE: [PATCH 2/4] mwifiex: remove redundant reset of cmd_wait_q status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andreas,

> From: Andreas Fenkart [mailto:afenkart@xxxxxxxxx]
> Sent: Friday, July 17, 2015 12:43 PM
> To: linux-wireless@xxxxxxxxxxxxxxx
> Cc: Amitkumar Karwar; Kalle Valo; Andreas Fenkart
> Subject: [PATCH 2/4] mwifiex: remove redundant reset of cmd_wait_q
> status
> 
> mwifiex_cancel_pending_ioctl is called only from
> mwifiex_cmd_timeout_func. There the wait_q status is set to -ETIMEDWAIT
> before calling this function. Whether we reset the status to -1 or leave
> it at -ETIMEDWAIT at end doesn't matter since both are != 0 hence mean
> failure
> 
> Signed-off-by: Andreas Fenkart <afenkart@xxxxxxxxx>
> ---
>  drivers/net/wireless/mwifiex/cmdevt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mwifiex/cmdevt.c
> b/drivers/net/wireless/mwifiex/cmdevt.c
> index 2f4715e..87b6dee 100644
> --- a/drivers/net/wireless/mwifiex/cmdevt.c
> +++ b/drivers/net/wireless/mwifiex/cmdevt.c
> @@ -1123,7 +1123,6 @@ mwifiex_cancel_pending_ioctl(struct
> mwifiex_adapter *adapter)
>  			}
>  		}
>  	}
> -	adapter->cmd_wait_q.status = -1;
>  }
> 
>  /*
> --
> 2.1.4

Acked-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx>

Regards,
Amitkumar
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux