On 07/22/2015 08:30 PM, nick wrote: > > > On 2015-07-22 01:28 PM, Grumbach, Emmanuel wrote: >> >> >> On 07/22/2015 07:39 PM, Nicholas Krause wrote: >>> This fixes error handling in the function iwl_pcie_enqueue_hcmd >>> by checking if all calls to the function wl_pcie_txq_build_tfd >>> have failed by returning a error code and if so jump to the goto >>> label out from the cleaning up of acquired resources before >> >> What tests did you run on your patch? >> > None did I miss something? I can't really accept a patch if you don't even test it, right? Your patch doesn't look problematic at first glance, but hitting these paths isn't easy and I am not very happy to change the behavior without direct testing. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html