On 07/07/15 04:19, David Binderman wrote: > Hello there, > > [linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874]: (style) A pointer can not be negative so it is either pointless or an error to check if it is. > > Source code is > > if (wilc_mac_thread < 0) { > > but > > struct task_struct *wilc_mac_thread; #include <linux/err.h> if (IS_ERR(wilc_mac_thread)) { -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html