> Johannes Berg wrote:
> On Wed, 2015-07-01 at 14:42 +0000, David Lin wrote:
> > > We can leave both selectable by developer testing as per your
> > suggestion, and assume users/integrators will know how to put the
> > driver they want in their system. We were warned about causing
> > confusion hence the conditioning in CONFIG. Do you feel there's no
> > concern leaving both driver in, not checking each other's presence?
> > We can comply either way.
>
> I think you should just leave both selectable.
>
OK, we will leave both of them selectable, and provide additional “NOTE” (warning) in the Kconfig HELP message.
>
> > > > > This looks OK, though I get a very strange dependency loop
> > > > > warning from Kconfig here.
> >
> > For the next patch, we will modify the code to still work even though
> > the target does not support DTS. So we can remove "select OF" from
> > Kconfig file.
>
> If the driver needs OF don't bother - the dependency loop is very long and the
> warning is rather strange.
>
> > > > > > writew(0x00, (void __iomem *)&priv->pcmd_buf[1]);
> > > > >
> > > > > cannot be right. This memory isn't __iomem, it's
> > > > > dma_alloc_coherent, so a simple write should be done.
> > > > >
> >
> > Without this casting, C=2 will cause a warning message like this:
> > "Warning: incorrect type in argument 2 (different address spaces)"
>
> Yes, but the warning is correct and the cast is wrong. This isn't __iomem, it's
> simply mapped, so you should just do a
> (u32 *)pcmd_buf[1] = 0;
>
> or something like that. The writev() to such a pointer cannot be right.
>
Understood. Thanks. Will make changes accordingly.
>
> > Johannes
Thanks,
David
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
